Skip to content

Conversation

michaelmkraus
Copy link
Contributor

Proposed changes

  • change color of label on hovered and active state

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@michaelmkraus michaelmkraus moved this to 👀 In review in UX Engineering Team Backlog Apr 17, 2025
@github-actions github-actions bot added the 🧱components Changes inside components folder label Apr 17, 2025
Copy link
Contributor

mfranzke
mfranzke previously approved these changes Apr 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • packages/components/src/styles/internal/_form-components.scss: Language not supported

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Apr 17, 2025
@github-actions github-actions bot removed the 📺showcases Changes to 1-n showcases label Apr 22, 2025
@nmerget
Copy link
Collaborator

nmerget commented Apr 23, 2025

There are some additonal things:

  • You need to check the disabled state the label is interactive
  • The radio[checked] shouldn't be interactive, the label shouldn't be interactive as well for this

@mfranzke
Copy link
Collaborator

mfranzke commented Apr 30, 2025

blocked by #4096, which needs to get finished first.

@nmerget nmerget self-requested a review May 6, 2025 12:12
@nmerget nmerget enabled auto-merge (squash) May 6, 2025 12:43
@nmerget nmerget merged commit 61941f5 into main May 7, 2025
73 checks passed
@nmerget nmerget deleted the feat-optimize-hover-data-inputs branch May 7, 2025 11:47
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog May 7, 2025
@michaelmkraus michaelmkraus restored the feat-optimize-hover-data-inputs branch May 8, 2025 11:27
Comment on lines +462 to +466
cursor: helpers.$cursor-pointer;
}

input {
cursor: helpers.$cursor-pointer;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelmkraus how is this related to changing the color ?

@mfranzke mfranzke added this to the 2.1.0 milestone May 12, 2025
@mfranzke mfranzke added this to Roadmap May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧱components Changes inside components folder
Projects
Status: No status
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants